Misc. cleanups. #12956
Merged
Misc. cleanups. #12956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Dec 9, 2018
| @@ -657,7 +657,7 @@ def set_data(self, *args): | |||
| *args : (N, 2) array or two 1D arrays | |||
| """ | |||
| if len(args) == 1: | |||
| x, y = args[0] | |||
| (x, y), = args | |||
There was a problem hiding this comment.
Not sure if that's really better in this context.
There was a problem hiding this comment.
I prefer this form as it's immediately clear that you're not dropping anything from args, i.e. that single line also asserts that args has length 1. (Yes, it's redundant with the line just above, but I still think it helps the readability.)
tacaswell
reviewed
Dec 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist