Deprecate setting the same property under two different aliases. #12962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow getting rid of the notion of alias priority, and is consistent with Python's behavior (as explained in the changelog entry).
d229bac to
0316ae1
Compare
|
I'd definitely see the point of doing this, but I do wonder how often this happens inadvertently in third-party packages like cartopy as properties from multiple sources gets merged together. We should also double-check with Cartopy on this because they are wrestling with property-setting issues, too. |
|
That's why it's going through a deprecation. |
tacaswell
approved these changes
Dec 11, 2018
|
Indeed, recall the pain we went through with py3.4 and things that worked half of the time... |
timhoffm
approved these changes
Dec 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow getting rid of the notion of alias priority, and is
consistent with Python's behavior (as explained in the changelog entry).
PR Summary
PR Checklist