Skip to content

Fail-fast when trying to run tests with too-old pytest. #12975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2018
Merged

Fail-fast when trying to run tests with too-old pytest. #12975

merged 1 commit into from
Dec 11, 2018
+5 −4

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 10, 2018

Otherwise the error message can be quite obscure.

e.g. #12945 (comment)

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.1 milestone Dec 10, 2018
@QuLogic
Copy link
Member

QuLogic commented Dec 10, 2018

We should set minversion in pytest.ini.

@anntzer
Fail-fast when trying to run tests with too-old pytest.
876becc 
Otherwise the error message can be quite obscure.
@anntzer
Copy link
Contributor Author

anntzer commented Dec 10, 2018

Ah, that's much better, thanks for pointing it out.

@tacaswell tacaswell merged commit 7157312 into matplotlib:master Dec 11, 2018
@anntzer anntzer deleted the pytest-version branch December 11, 2018 22:49
@anntzer anntzer mentioned this pull request Jan 1, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @QuLogic @timhoffm @tacaswell