Skip to content

Add category module to docs #13006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Conversation

timhoffm
Copy link
Member

PR Summary

This adds the category module to the docs (was simply missing).

@timhoffm timhoffm added this to the v3.0.2-doc milestone Dec 17, 2018
@timhoffm
Copy link
Member Author

Had to edit category.py because sphinx was complaining on invalid docstrings. Therefore remilestoning.

@timhoffm timhoffm modified the milestones: v3.0.2-doc, v3.0.3 Dec 17, 2018
@tacaswell tacaswell requested review from anntzer and story645 and removed request for anntzer December 17, 2018 20:24
@story645
Copy link
Member

I'm not sure if this api was supposed to be public/findable in the docs, but it's been in mpl for 2+ years so I'm ok with this PR going in.

@tacaswell tacaswell merged commit 406e453 into matplotlib:master Dec 17, 2018
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Dec 17, 2018
@timhoffm
Copy link
Member Author

timhoffm commented Dec 17, 2018

I'm not sure if this api was supposed to be public/findable in the docs, but it's been in mpl for 2+ years so I'm ok with this PR going in.

Well if it shouldn't be public, it should move to _category. No strong opinion about that.

I just document what looks public 😝

@timhoffm timhoffm deleted the doc-category branch December 17, 2018 21:11
tacaswell added a commit that referenced this pull request Dec 18, 2018
…006-on-v3.0.x

Backport PR #13006 on branch v3.0.x (Add category module to docs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants