Enable local doc building without git installation #13015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
previously requested changes
Dec 18, 2018
There was a problem hiding this comment.
This is done this way so that the you can build the docs of a released version of matplotlib (which will report as the tag name) but still capture what the commit the docs were built off of was.
For example, the currently published docs report "Doc version v3.0.2-2-g91e2d00a8" but with this change would report just 'v3.0.2'.
|
Ah fair enough, maybe adding a |
|
I think the best fix would be to replicate part of versioneer and use the git export templating, a quick fix would be to put the subprocess call in a |
|
Our last two comments passed in the ether, looks like |
d4879ac to
0c19a56
Compare
anntzer
reviewed
Jan 3, 2019
tacaswell
approved these changes
Jan 13, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 14, 2019
tacaswell
added a commit
that referenced
this pull request
Jan 14, 2019
…015-on-v3.0.x Backport PR #13015 on branch v3.0.x (Enable local doc building without git installation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just uses the version that
versioneergives Matplotlib. This should be a 1:1 mapping between commits and version numbers (my local build givesDoc version 3.0.2.post1037.dev0+g0fec7f1c3.).Fixes #13013