cairo: speed up the cairo append_path() slow path #13040
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the Gtk3Cairo backend with wire3d_animation_sgskip.py: Before: 9.15 fps After: 10.93 fps Converting the code to int makes the comparisons faster.
|
This in combination with #13039 makes the slow path faster than the fast one and the fast one could be removed. |
lazka
added a commit
to lazka/matplotlib
that referenced
this pull request
Dec 23, 2018
With the performance improvements in matplotlib#13040 and matplotlib#13039 the old slow path is now faster than the previously fast one. And it also works with pycairo.
6 tasks
|
This will be affected by the type changes proposed in #13039 (comment). I suggest to get #13039 in first and then revisit how this code here should handle types. |
|
#13039 is in which made the change the other way (making everything int8) do we still need this? |
|
Yeah, this is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Using the Gtk3Cairo backend with wire3d_animation_sgskip.py:
Before: 9.15 fps
After: 10.93 fps
Converting the code to int makes the comparisons faster.
PR Checklist