Skip to content

pathlibify/cleanup triage_tests.py. #13058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2018
Merged

pathlibify/cleanup triage_tests.py. #13058

merged 1 commit into from
Dec 29, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 28, 2018

  • General pathlibification.
  • Entry.same is used only once and may as well be inlined.
  • Entry.copy_file should be a free function, not a method.
  • find_failing_tests can just sort the paths directly and then construct
    the Entries, rather than constructing the entries and getting their
    paths out for sorting.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
pathlibify/cleanup triage_tests.py.
daf2e66 
- General pathlibification.
- Entry.same is used only once and may as well be inlined.
- Entry.copy_file should be a free function, not a method.
- find_failing_tests can just sort the paths directly and then construct
  the Entries, rather than constructing the entries and getting their
  paths out for sorting.
@anntzer anntzer added this to the v3.1 milestone Dec 28, 2018
@QuLogic QuLogic merged commit 9e7650e into matplotlib:master Dec 29, 2018
@anntzer anntzer deleted the pathlib-triage_tests branch December 29, 2018 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @timhoffm