-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Use default colour cycle in more examples #13063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically ok. However, I'm not a fan of using 'Cn' in cases that do not relate to a color sequence. Instead, we should use the color names 'tab:blue' etc instead. I've noted this down for one example but there are more similar cases in here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @timhoffm 's comments. 👍 on merging with those changes.
Co-Authored-By: dstansby <dstansby@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flake8 complains:
./examples/pyplots/pyplot_two_subplots.py:0:1: X100 Superfluous per-file-ignores for E302
Can be merged after that's fixed.
Makes lots of the examples look more pleasing to the eye!