Don't use deprecated np.random.random_integers. #13088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ additional cleanups to boxplot example.
anntzer
commented
Jan 3, 2019
| @@ -95,15 +94,14 @@ | |||
|
|
|||
| # Generate some random indices that we'll use to resample the original data | |||
| # arrays. For code brevity, just use the same random indices for each array | |||
| bootstrapIndices = np.random.random_integers(0, N - 1, N) | |||
anntzer
commented
Jan 3, 2019
| @@ -126,21 +124,19 @@ | |||
| ax1.set_ylabel('Value') | |||
|
|
|||
| # Now fill the boxes with desired colors | |||
| boxColors = ['darkkhaki', 'royalblue'] | |||
| numBoxes = numDists*2 | |||
| medians = list(range(numBoxes)) | |||
There was a problem hiding this comment.
medians gets fully overwritted in the loop below.
anntzer
commented
Jan 3, 2019
| @@ -149,39 +145,40 @@ | |||
| medianX.append(med.get_xdata()[j]) | |||
| medianY.append(med.get_ydata()[j]) | |||
| ax1.plot(medianX, medianY, 'k') | |||
| medians[i] = medianY[0] | |||
There was a problem hiding this comment.
this line can be lifted out of the internal loop (and overwrites medians, as promised above).
dstansby
approved these changes
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and additional cleanups to boxplot example.
PR Summary
PR Checklist