Skip to content

Remove a duplicate attribute setting. #13095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2019
Merged

Remove a duplicate attribute setting. #13095

merged 1 commit into from
Jan 4, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 3, 2019

self.figure.dpi is already set to dpi by the _setattr_cm
contextmanager a few lines earlier.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Remove a duplicate attribute setting.
41d8fbc 
`self.figure.dpi` is already set to `dpi` by the `_setattr_cm`
contextmanager a few lines earlier.
@tacaswell tacaswell added this to the v3.1 milestone Jan 4, 2019
@tacaswell tacaswell merged commit 13a617b into matplotlib:master Jan 4, 2019
@anntzer anntzer deleted the duplicate-set branch January 4, 2019 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @QuLogic @jklymak @tacaswell