Skip to content

Restore the font cache on Travis. #13100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2019
Merged

Restore the font cache on Travis. #13100

merged 1 commit into from
Jan 6, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 4, 2019

PR Summary

followup to #9787 (comment)
attn @jklymak

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak
Copy link
Member

jklymak commented Jan 4, 2019

I'll merge, or feel free to self-merge, when CI passes... (don't thnk this needs two reviews)

dstansby
dstansby requested changes Jan 5, 2019
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the travis failure is real, on a font related test.

@anntzer anntzer force-pushed the travis-font-cache branch from 9b118ba to 356c38b Compare January 5, 2019 22:55
timhoffm
timhoffm reviewed Jan 6, 2019
View reviewed changes
@anntzer anntzer force-pushed the travis-font-cache branch from 356c38b to df2497e Compare January 6, 2019 12:38
@anntzer
Copy link
Contributor Author

anntzer commented Jan 6, 2019 •
edited
Loading

@dstansby now fixed, was likely some persistent cache issue...

@dstansby dstansby merged commit f399719 into matplotlib:master Jan 6, 2019
@dstansby dstansby added this to the v3.1 milestone Jan 6, 2019
@anntzer anntzer deleted the travis-font-cache branch January 6, 2019 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @jklymak @timhoffm @dstansby