Simplify color conversion backcompat shim. #13134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One doesn't need to have separate docstrings for the old and the new method; the new implementation will just reuse the "new" docstrings in the backcompat layer. At least half of the docstring of the ColorConverter class is outdated (even the single colorConverter instance is unneeded now) so just rewrite the whole thing.
QuLogic
approved these changes
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One doesn't need to have separate docstrings for the old and the new
method; the new implementation will just reuse the "new" docstrings in
the backcompat layer.
At least half of the docstring of the ColorConverter class is outdated
(even the single colorConverter instance is unneeded now) so just
rewrite the whole thing.
(@tacaswell argued against deprecating ColorConverter in #6382 (comment); I don't really care either way.)
PR Summary
PR Checklist