Skip to content

Update example Step Demo #13148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2019
Merged

Update example Step Demo #13148

merged 1 commit into from
Jan 10, 2019

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Jan 10, 2019 •
edited
Loading

PR Summary

  • Add a sentence on the purpose of the example.
  • Add markers for the data points so that the effect of where is easier to see.
  • Remove the masked data set. I don't see what that should teach in context of the example. If somebody can explain the purpose, I'm happy to re-add it.

This is how it looks like

@timhoffm timhoffm added this to the v3.1 milestone Jan 10, 2019
jklymak
jklymak reviewed Jan 10, 2019
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but have we decided if we are planning to move most of the examples to OO?

@timhoffm
Copy link
Member Author

Not sure. Can do if you want. - But it's also trivial to search and replace later.

@jklymak
Copy link
Member

jklymak commented Jan 10, 2019

Sure, well lets merge as an improvement, and we can disucss further whether we want to change examples going forward...

@jklymak
Copy link
Member

jklymak commented Jan 10, 2019

Merging w/o test CI - flake8 passed and the rendered pages look good.

@jklymak jklymak merged commit 910f9fd into matplotlib:master Jan 10, 2019
@timhoffm timhoffm deleted the example-step branch January 10, 2019 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak left review comments

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@timhoffm @jklymak