TST: Fix incorrect call to pytest.raises. #13194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
approved these changes
Jan 17, 2019
timhoffm
approved these changes
Jan 18, 2019
timhoffm
requested changes
Jan 18, 2019
The `message` parameter is actually the message to print when it fails, but we want to check the exception message, which is the `match` parameter.
3233d15 to
78ab43f
Compare
timhoffm
approved these changes
Jan 18, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 18, 2019
NelleV
added a commit
that referenced
this pull request
Jan 20, 2019
…194-on-v3.0.x Backport PR #13194 on branch v3.0.x (TST: Fix incorrect call to pytest.raises.)
QuLogic
added a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 3, 2019
The `message` parameter is actually the message to print when it fails, but we want to check the exception message, which is the `match` parameter.
QuLogic
added a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 8, 2019
The `message` parameter is actually the message to print when it fails, but we want to check the exception message, which is the `match` parameter.
QuLogic
added a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 8, 2019
The `message` parameter is actually the message to print when it fails, but we want to check the exception message, which is the `match` parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The
messageparameter is actually the message to print when it fails, but we want to check the exception message, which is thematchparameter.This causes a warning in new pytest.
PR Checklist