Skip to content

Avoid private API in some examples. #13202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jan 17, 2019

PR Summary

Refs #13199; all but the last are fixed.

PR Checklist

  • [N/A] Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Refs matplotlib#13199; all but the last are fixed.
@QuLogic QuLogic added this to the v3.1 milestone Jan 17, 2019
@@ -20,16 +20,15 @@ def get_demo_image():
return z, (-3, 4, -4, 3)


def add_inner_title(ax, title, loc, size=None, **kwargs):
def add_inner_title(ax, title, loc, **kwargs):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I removed size here because it was unused and didn't want to leave it cluttering up the example.

@anntzer
Copy link
Contributor

anntzer commented Jan 17, 2019

thanks!

@anntzer anntzer merged commit 99af9e3 into matplotlib:master Jan 17, 2019
@QuLogic QuLogic deleted the no-private-api branch January 17, 2019 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants