Backport #13205 on branch v3.0.x (Add xvfb service to travis) #13216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
06e99aa to
ae56447
Compare
a1ab49b to
c129091
Compare
|
Restarted 3.5 which was the only one that failed and it failed on the Qt tests. I wonder if there is some roll-over going on where we are getting a mixed population of workers, some the new way works and some the oldway works? |
|
Yeah, the 3.5 build is getting a |
|
It is because we force the dist back to trusty, lets see what happens if we drop that.... |
This is to make sure we have the xvfb as a service
QuLogic
approved these changes
Jan 18, 2019
|
fui! Great! Thanks a lot for fixing that last problem. |
timhoffm
approved these changes
Jan 19, 2019
|
Hm, maybe I should not have squashed the commits. Should I revert and merge without squashing? |
|
No, it's good!
…On Sat, Jan 19, 2019, 7:30 PM Tim Hoffmann ***@***.*** wrote:
Hm, maybe I should not have squashed the commits. Should I revert and
merge without squashing?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#13216 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AALR3uTlBGk9gxbqGJ3dAX87GXTf2geYks5vEte_gaJpZM4aHOSy>
.
|
|
Thanks!
On Sat, Jan 19, 2019, 7:36 PM Nelle Varoquaux <nelle.varoquaux@gmail.com
wrote:
… No, it's good!
On Sat, Jan 19, 2019, 7:30 PM Tim Hoffmann ***@***.***
wrote:
> Hm, maybe I should not have squashed the commits. Should I revert and
> merge without squashing?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#13216 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AALR3uTlBGk9gxbqGJ3dAX87GXTf2geYks5vEte_gaJpZM4aHOSy>
> .
>
|
|
Most of our backports are squashed anyway (all automated ones are.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Attempt to fix some of our Travis failures on v3.0.x. Supersedes #13206
MarkInfo objects were removed in pytest 4.0. The other solution would be to backport the PR that fixes this from our master branch.
PR Checklist