Skip to content

Interpret unitless bar widths for unitized data as relative to spacing. #13254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Interpret unitless bar widths for unitized data as relative to spacing. #13254

wants to merge 1 commit into from

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 21, 2019

PR Summary

Implements the proposal in #13236.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer mentioned this pull request Jan 21, 2019
Open
@anntzer
Copy link
Contributor Author

anntzer commented Jan 21, 2019

So this actually breaks some tests that were doing

bar([3, 4, 5], ["foo", "bar", "baz"])

and expected to get
test
which is pretty nonsensical IMO (with this PR, this fails when trying to add 0 (bottom) to "foo").
Obviously there's backcompat concerns (also for the case of units that's don't define addition -- there's an example in the docs (see the circleci failure), but I'd argue this doesn't really make sense either). Thoughts?

@jklymak jklymak mentioned this pull request Jan 23, 2019
Merged
6 tasks
@jklymak
Copy link
Member

jklymak commented Apr 23, 2021

Is this still needed after #12903? I'm closing, but feel free to request a reopen

@jklymak jklymak closed this Apr 23, 2021
@anntzer
Copy link
Contributor Author

anntzer commented Apr 23, 2021

I think this was attempting to solve a different problem, but well, units...

@anntzer anntzer deleted the bar-units branch April 23, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: units and array ducktypes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anntzer @jklymak