Skip to content

Select RadioButtons by closest in position. #13268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 25, 2019
Merged

Select RadioButtons by closest in position. #13268

merged 3 commits into from
Jan 25, 2019

Conversation

mromanie
Copy link
Contributor

Modify the selection criterion for RadioButtons so that the closest to the mouse click is activated.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@mromanie
Select RadioButtons by closest in position.
6b2c718 
Modify the selection criterion for RadioButtons so that the closest to the mouse click is activated.
@mromanie
Copy link
Contributor Author

Solves #13145

@mromanie mromanie mentioned this pull request Jan 23, 2019
Closed
@anntzer
Copy link
Contributor

anntzer commented Jan 23, 2019

This causes a ValueError (min() arg is an empty sequence) to be thrown if clicking in the rectangle, but not on a radio button.

@mromanie
Copy link
Contributor Author

You're right! I've uploaded a change that should fix it.

timhoffm
timhoffm reviewed Jan 23, 2019
View reviewed changes
@timhoffm timhoffm merged commit 5d475d1 into matplotlib:master Jan 25, 2019
@timhoffm
Copy link
Member

Thanks, and congratulations to your first contribution to matplotlib! Would be nice to see you back some time.

@QuLogic QuLogic added this to the v3.1 milestone Jan 25, 2019
@mromanie
Copy link
Contributor Author

:-)

If I understand correctly, the change will be included in version 3.1. Do you know when it's going to be released?

@timhoffm
Copy link
Member

In about a month or so.

@QuLogic QuLogic mentioned this pull request Mar 19, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: widgets/UI
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mromanie @anntzer @timhoffm @QuLogic @dstansby