-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
MAINT install of pinned vers for travis #13281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pinned version of dependencies need to be installed *after* the rest of the packages. This will downgrade them. Else, sometimes, pip tries to installs the wrong version of the package, and fails.
Shouldn't this go to vthe 3.0.2-doc to fix #13274? |
No clue. I'm super confused on why we have a documentation branch that moves forwards after the code is released. This is also not a documentation fix. |
I still think we should apply something like #12398 and not run full tests for doc branches. |
This PR still needs to get merged. It fixes something that is unrelated to our docs. |
I... don't think the interpretation of the problem is correct? Right now (since #12878) the 3.0.2-doc branch has the following
and the following
so we're giving pip contradictory constraints on pytest. I guess it would be nicer if pip signalled this properly, but I think(?) the correct fix on our side is to make the constraints not contradictory anymore. |
@anntzer The new version is fine, as it installs all the dependencies in the first file, and then installs the pinned version from the second file. Sure, it installs and then downgrades pytests, but it works, and the logic is not flawed. Would unpinning the version in travis_all.txt work? No, because the new version of pip doesn't care about the order of the requirement files nor whether one version contains a pinned version or the other doesn't. In particular, in our last failed build on 3.0.x, pytest-xdist fails to be installed because it is attempting to install the newer unpinned version from travis_all.txt instead of the pinned version of travis35.txt Is it the best way to do this? No, it is not, as it installs some of the packages twice. But we have too many dependencies to be able to have a clean setup that doesn't require maintaining entirely separate requirements files for all of the versions we are testing. |
Would #12398 not fix the problem much more simply by just not running the test suite on the doc branch? |
This patch is not on the documentation branch. |
I am extremely confused now. Isn't the 3.0.x branch just fine? The last 5 builds are green on https://travis-ci.org/matplotlib/matplotlib/branches. |
@anntzer I'll double check that it works on the doc branch once I'm back from Australia. |
Pinned version of dependencies need to be installed after the rest of
the packages. This will downgrade them. Else, sometimes, pip tries to installs
the wrong version of the package, and fails.
Right now, this isn't a problem on master, but this should probably still be ported forward to master. Happy to create a PR.
This is due to a pip release