Simplify some calculations in polar.py. #13294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(For the second modifications to RadialTick: the angle/tick_angle calculations are moved outside of the if block to not inherit the incorrect text_angle from the code above, even though in practice it didn't really matter as label2 (to which the angle is applied) is set to invisible in the other side of the if block.)
tacaswell
approved these changes
Jan 27, 2019
jklymak
approved these changes
Jan 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(For the second modifications to RadialTick: the angle/tick_angle
calculations are moved outside of the if block to not inherit the
incorrect text_angle from the code above, even though in practice it
didn't really matter as label2 (to which the angle is applied) is set to
invisible in the other side of the if block.)
PR Summary
PR Checklist