Patched pyplot.subplots for squeeze==False #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For completeness this looks like the commit that introduced the bug. |
| @@ -799,6 +799,9 @@ def subplots(nrows=1, ncols=1, sharex=False, sharey=False, squeeze=True, | |||
| ret = fig, axarr[0,0] | |||
| else: | |||
| ret = fig, axarr.squeeze() | |||
| else: | |||
| # returned axis array will be always 2-d, even if nrows=ncols=1 | |||
| return fig, axarr.reshape(nrows, ncols) | |||
|
|
|||
|
|
|||
| return ret | |||
There was a problem hiding this comment.
This last line will now never get called so should be removed for cleanliness sake.
There was a problem hiding this comment.
It gets called if squeeze == True. The problem was that if squeeze==False, ret never gets defined. I changed 804 so that it's clearer and removed a blank line.
ddale
added a commit
that referenced
this pull request
Jun 16, 2011
Patched pyplot.subplots for squeeze==False
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If squeeze == False, ret was never defined. I just copied over the code from 1.0.1 release.