Skip to content

TST: deregister pandas #13304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Jan 28, 2019

PR Summary

Pandas is planning to drop automatic registration of their converters for matplotlib so that import pandas no longer imports them. In preparation for that, we should deregister the pandas converters.

Note this should work fine for any of the tests. pandas converters were mainly for datetime, and I think our datetime converters now handle most of the cases properly.

Of course if we want to test pandas converters, separate tests could call pandas.plotting.register_matplotlib_converters().

#11391 (comment)

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak jklymak changed the title TST: dregister pandas TST: deregister pandas Jan 28, 2019
@tacaswell tacaswell added this to the v3.1 milestone Jan 28, 2019
@dstansby dstansby merged commit c2ff409 into matplotlib:master Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants