Skip to content

Backport PR #12678 on branch v3.0.x #13308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2019
Merged

Backport PR #12678 on branch v3.0.x #13308

merged 1 commit into from
Jan 29, 2019

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Jan 28, 2019

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak jklymak added this to the v3.0.3 milestone Jan 28, 2019
QuLogic
QuLogic requested changes Jan 28, 2019
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please amend and remove the conflict markers entirely, or squash-merge.

@jklymak jklymak force-pushed the auto-backport-of-pr-12678-on-v3.0.x branch from 7ae4a36 to 48e839e Compare January 28, 2019 23:47
@dstansby dstansby merged commit 9f6cf2b into matplotlib:v3.0.x Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic requested changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@jklymak @QuLogic @dstansby @tacaswell