Simplify and generalize BezierSegment. #13355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
commented
Feb 3, 2019
| @@ -25,7 +25,7 @@ def __init__(self, canvas, cankill): | |||
| # for simplicity I'm going to reuse a bitmap from wx, you'll | |||
| # probably want to add your own. | |||
| tool = self.AddTool(wx.ID_ANY, 'Click me', _load_bitmap('back.png'), | |||
| 'Activate custom contol') | |||
| 'Activate custom control') | |||
There was a problem hiding this comment.
noticed because the docstring of BezierSegment had the same typo :)
cbbf05d to
d6aae2f
Compare
dstansby
reviewed
Feb 4, 2019
|
edit: let's also support arbitrary N, while we're at it... |
timhoffm
reviewed
Jun 2, 2019
|
But the patch is indirectly tested by other tests (as shown by coverage). |
timhoffm
approved these changes
Jul 21, 2019
As it turns out, it is simpler to write the d-dimensional version than the 2-dimensional special case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it turns out, it is simpler to write the d-dimensional version than
the 2-dimensional special case.
I initially tried to rebase the original PR (#9686, from @ijackson) but the codebase has diverged to much for it to make sense.
PR Summary
PR Checklist