Doc: examples update #13399
Doc: examples update #13399
Conversation
1dc89a6 to
d8a80c6
Compare
|
Can we remove the one in units? We have more than 500 examples: we should aim at reducing this number. It's one of the reasons why users struggle with finding examples matching what they want in the gallery. |
|
(I agree that the example in question makes way more sense in lines, bars, and markers) |
|
I think it's pretty cool to have the units explained by drawing the parallel to an existing example. This allows to grasp how it works. However, I'd agree that some of the unit examples could be merged into one longer example with more code sections. Because either you dive into this stuff, then you can read everything in one page; or not, then it's easier to ignore a lower number of examples. If you want to remove an example I'd vote for the one that this PR disentangles (the one with Johnny Doe's sports performance) from the canonical grouped bar chart example, because it is long, and essentially only shows a real world use case someone may have had a couple of years ago. |
c1c0f30 to
b893006
Compare
| with error bars. This example shows a ways to create a grouped bar chart | ||
| with Matplotlib and also how to annotate bars with labels. | ||
|
|
||
| Credit: Josh Hemann |
There was a problem hiding this comment.
Ok, done, though I'm not sure about the general policy.
| @@ -0,0 +1,78 @@ | |||
| """ | |||
| ============================ | |||
| Grouped Barchart with labels | |||
There was a problem hiding this comment.
"bar chart" (two words, uncapitalized)
b893006 to
f7b2172
Compare
There was a problem hiding this comment.
Semi-OT: ax2.set_xlabel(('Percentile Ranking Across ' in barchart_demo.py does not show up in the plot
https://535-100939689-gh.circle-artifacts.com/0/home/circleci/project/doc/build/html/gallery/statistics/barchart_demo.html#sphx-glr-gallery-statistics-barchart-demo-py
Maybe because ax2 is a twinned axes?
f7b2172 to
64ac509
Compare
|
Already in 1.3.1 this label did not appear, so maybe it actually never did. In any case I corrected it. |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
|
I think the back port is pretty optional here... |
|
Probably not necessary since we're going to release pretty soon. |
PR Summary
Update 3 examples:
Barchart example
In #12244 the Barchart example got removed from the "Lines, Bars, and Markers" gallery section. However, a bar chart example should be in the section named "Bars". It is also one of the most frequent questions on stackoverflow on how to label bars. Links to the example should not be broken. Inside this example, the coordinates of the labels should be placed at an offset from the bar tip in absolute units, instead of data units, such that people will not struggle to apply the example to their very different data ranges.
I also corrected the coordinate placement in the statistics example the bar example got merged with and changed the random state, such that some of the stylings used in that example actually take effect. In total, I'm not convinced that this example is actually needed, or maybe better shown in the showcase section? That is in any case beyond this PR.
Polar bar chart example
This example was wrongly named. Also it used a loop to set colors, which is unnecessary.
Image interpolation example
Change the figure size to let it fit into the webpage and remove a redundant line.
PR Checklist