Skip to content

Deemphasize numeric locations for legend() in docs. #13411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 11, 2019

... as well as the "right" synonym to "center right".

(Note that despite the mention of backcompat, I am not proposing a
deprecation here.)

Per #11127 (comment), which I agree with.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

... as well as the "right" synonym to "center right".

(Note that despite the mention of backcompat, I am not proposing a
deprecation here.)
The location of the legend.

The strings
``'upper left', 'upper right', 'lower left', 'lower right'``
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that strings don't usually get double-backquoted in the docs, but I did so on purpose here as it seems better to add a bit of emphasis to the list of valid values. (The linebreaks are for the same reason.)

@ImportanceOfBeingErnest ImportanceOfBeingErnest added this to the v3.1.0 milestone Feb 11, 2019
@ImportanceOfBeingErnest
Copy link
Member

This could also be part of #12679 if some decision is made.

@ImportanceOfBeingErnest ImportanceOfBeingErnest merged commit 5639790 into matplotlib:master Feb 14, 2019
@anntzer anntzer deleted the legendnumeric branch February 14, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants