Simplify decade up- and down-rounding, and symmetrize expansion of degenerate log scales. #13413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
reviewed
Feb 14, 2019
jklymak
approved these changes
Feb 14, 2019
6ac5d20 to
3b5dc4d
Compare
tacaswell
reviewed
Feb 23, 2019
lib/matplotlib/ticker.py
Outdated
|
|
||
| def _decade_less(x, base): | ||
| """ | ||
| Return the smallest integer power of *base* that's less than *x*. |
There was a problem hiding this comment.
Suggested change
| Return the smallest integer power of *base* that's less than *x*. | |
| Return the largest integer power of *base* that's less than *x*. |
tacaswell
approved these changes
Feb 23, 2019
Instead of `decade_up` and `decade_down`, use more explicit `_decade_less`, `_decade_less_equal`, etc. which moreover also handle negative values (used by the symlog scale). Previously, `semilogx([.1, .1], [1, 2])` would autoscale the x-axis from a bit less than 0.1 to a bit more than 1, because 0.1 == 10**-1 so decade_down(0.1) would use `floor(-1) == -1` and return 0.1, while decade_up(0.1) would return 1. With this PR, `semilogx([.1, .1], [1, 2])` instead autoscales the x-axis from a bit less than 0.01 to a bit more than 1 (i.e. one decade on each side), which seems more logical.
3b5dc4d to
46db9e2
Compare
|
Should be ready to go now. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Feb 24, 2019
…and symmetrize expansion of degenerate log scales.
|
Something went wrong ... Please have a look at my logs. |
dstansby
added a commit
that referenced
this pull request
Feb 24, 2019
…413-on-v3.1.x Backport PR #13413 on branch v3.1.x (Simplify decade up- and down-rounding, and symmetrize expansion of degenerate log scales.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
decade_upanddecade_down, use more explicit_decade_less,_decade_less_equal, etc. which moreover also handlenegative values (used by the symlog scale).
Previously,
semilogx([.1, .1], [1, 2])would autoscale the x-axis froma bit less than 0.1 to a bit more than 1, because 0.1 == 10**-1 so
decade_down(0.1) would use
floor(-1) == -1and return 0.1, whiledecade_up(0.1) would return 1.
With this PR,
semilogx([.1, .1], [1, 2])instead autoscales the x-axisfrom a bit less than 0.01 to a bit more than 1 (i.e. one decade on each
side), which seems more logical.
PR Summary
PR Checklist