-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC: update release guide #13421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: update release guide #13421
Conversation
Co-Authored-By: tacaswell <tcaswell@gmail.com>
Co-Authored-By: tacaswell <tcaswell@gmail.com>
Co-Authored-By: tacaswell <tcaswell@gmail.com>
Thank you @QuLogic |
doc/api/api_changes.rst
Outdated
|
||
The list below is a table of contents of individual files from the 'next_api_changes' folder. | ||
When a release is made | ||
The list below is a table of contents of individual files from the 'next_api_changes' folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent by the same amout as the following list items. (Can never decide if I want 3 or 4 spaces in rst files 😃 ).
---------------------------- | ||
|
||
Before tagging, update the "what's new" and API changes listings. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to be very clear add a line
For "what's new"
Maybe add an info admonition to the top of the page "This document is only relevant for matplotlib release managers." While the first sentence reads "A guide for developers who are doing a matplotlib release.", it cannot hurt to make it very obvious that this page is of no concern to the bypasser. People don't read precisely 😄 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tacaswell !
I'm not merging as there are still comments remaining, but for me 👍 It's already a huge improvements on what we had before.
Co-Authored-By: tacaswell <tcaswell@gmail.com>
Co-Authored-By: tacaswell <tcaswell@gmail.com>
PR Summary
PR Checklist