API: un-deprecate keyword only args to set_xlim, set_ylim #13425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were originally documented and deprecated in matplotlib#11137 however in later discussion we learned: - the 'left, right' / 'top, bottom' names don't make sense in the context of non-rectangular plots - we have at least one frustrated user The original names were `xmin, xmax` but were changed to `left, right` in 9ca5db0 (pre 1.0) and the kwarg popping was added for back-compatibility.
anntzer
approved these changes
Feb 13, 2019
timhoffm
reviewed
Feb 13, 2019
| @@ -154,8 +154,9 @@ Different exception types for undocumented options | |||
| and ``right`` arguments. :meth:`~matplotlib.axes.Axes.set_ylim` and the | |||
| 3D equivalents (e.g. :meth:`~mpl_toolkits.axes.Axes3D.set_zlim3d`) had a | |||
| corresponding problem. | |||
| The ``_min`` and ``_max`` arguments are now deprecated, and a ``TypeError`` | |||
| will be raised if they would override the earlier limit arguments. | |||
| A ``TypeError`` will be raised if they would override the earlier | |||
There was a problem hiding this comment.
It's reasonable to modify the changes in 3.0 section of the 3.1 docs. Additionally, I would add an entry to the section "changes in 3.1". People typically do not read the changelog of past versions.
jklymak
approved these changes
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were originally documented and deprecated in #11137 however
in later discussion we learned:
context of non-rectangular plots
The original names were
xmin, xmaxbut were changed toleft, rightin 9ca5db0 (pre 1.0) and the kwarg
popping was added for back-compatibility.
PR Summary
PR Checklist