BLD: only try to get freetype src if src does not exist #13455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Third time's the charm? |
anntzer
reviewed
Feb 18, 2019
| tgz.extractall("build") | ||
| # do we need to download / load the source from cache? | ||
| if not os.path.exists(src_path): | ||
| if not os.path.exists('build'): |
There was a problem hiding this comment.
this belongs out of the main if? (if the source tree exists but not the buildddir, you still want to mkdir build)
There was a problem hiding this comment.
The src path is in build (see L954) so if we have the source dir, build exists.
anntzer
approved these changes
Feb 18, 2019
timhoffm
approved these changes
Feb 18, 2019
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Feb 18, 2019
…c does not exist
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Feb 18, 2019
…oad_logic BLD: only try to get freetype src if src does not exist
dstansby
added a commit
that referenced
this pull request
Feb 18, 2019
…455-on-v3.0.x Backport PR #13455 on branch v3.0.x (BLD: only try to get freetype src if src does not exist)
NelleV
added a commit
that referenced
this pull request
Feb 19, 2019
…-v2.2.x Merge pull request #13455 from tacaswell/fix_freetype_download_logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13450 (again)
PR Summary
PR Checklist