Skip to content

Document histogramming pre-binned data. #13459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2019
Merged

Document histogramming pre-binned data. #13459

merged 1 commit into from
Feb 23, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 18, 2019

This simple solution is slightly modified from an original idea by
@mhedges.

In my view, this closes #6669.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Document histogramming pre-binned data.
eae2b7f 
This simple solution is slightly modified from an original idea by
@mhedges.
@HDembinski
Copy link

I am in favor of documenting this as an intermediate solution, but I argue in #6669 that this is an awkward use of the hist interface. In my view, this does not close #6669.

@anntzer
Copy link
Contributor Author

anntzer commented Feb 18, 2019

I do acknowledge your disagreement (that's why I specifically said in my view).

@tacaswell tacaswell added this to the v3.1.0 milestone Feb 18, 2019
tacaswell
tacaswell approved these changes Feb 23, 2019
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favor of merging this now (as it works and documents how to solve the problem) and also moving forward with extending the hist API to support this more 'natively'.

@timhoffm
Copy link
Member

IMHO this would better be documented in a standalone example and and not in a comment of a parameter. But this is better than nothing.

@dstansby dstansby merged commit 74640bb into matplotlib:master Feb 23, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 23, 2019
@dstansby
Backport PR matplotlib#13459: Document histogramming pre-binned data.
127adc7
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 23, 2019
Merged
timhoffm added a commit that referenced this pull request Feb 23, 2019
@timhoffm
Merge pull request #13505 from meeseeksmachine/auto-backport-of-pr-13…
35fbbb5 
…459-on-v3.1.x

Backport PR #13459 on branch v3.1.x (Document histogramming pre-binned data.)
@anntzer anntzer deleted the hist-pre-binned branch February 24, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

[Feature request] Functions for "manually" plotting histograms
5 participants
@anntzer @HDembinski @timhoffm @tacaswell @dstansby