Skip to content

Deprecate backend_wx.IDLE_DELAY. #13473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2019
Merged

Deprecate backend_wx.IDLE_DELAY. #13473

merged 1 commit into from
Feb 21, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 20, 2019

per changelog.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.1.0 milestone Feb 20, 2019
@dopplershift
Copy link
Contributor

I think when we support python >=3.7, we’ll have the hooks necessary to actually warn about this.

@anntzer
Copy link
Contributor Author

anntzer commented Feb 20, 2019 •
edited
Loading

It's actually not much harder to emit a warning on Py3.6 (#10735); actually I don't like the module-level __getattr__ addtion in Py3.7 at all :/ as the tools to do that were already present, and the module-level __getattr__ introduces a weird exception to the rule that dunders are looked up on the class (here that would be ModuleType), not on the instance (the module itself).

@timhoffm timhoffm merged commit 1d7494f into matplotlib:master Feb 21, 2019
@anntzer anntzer deleted the IDLE_DELAY branch February 21, 2019 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
GUI: wx
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @dopplershift @tacaswell @timhoffm