Animation: interactive zoom/pan with blitting does not work #13488
Conversation
In an animation using blitting that contains some static graphics elements, the static parts of the figure are not updated after an interactive zoom/pan event. However, they are correctly updated after an resize event.
|
This seems OK. Is the test just to run what you did in #13478? It would be good if a blitting expert chimed in. Assigning one ;-) |
lib/matplotlib/animation.py
Outdated
| @@ -1222,6 +1222,14 @@ def _setup_blit(self): | |||
| # axes | |||
| self._blit_cache = dict() | |||
| self._drawn_artists = [] | |||
| def remove_from_cache(ax): | |||
| try: | |||
| del self._blit_cache[ax] | |||
There was a problem hiding this comment.
Could replace the whole block with:
self._blit_cache.pop(ax, None)There was a problem hiding this comment.
@dopplershift,
I really like your proposal. The second argument of dict.pop did not come to my mind. We could make my proposal much more concise:
self._drawn_artists = []
for ax in self._fig.axes:
ax.callbacks.connect('xlim_changed',
lambda ax: self._blit_cache.pop(ax, None))
ax.callbacks.connect('ylim_changed',
lambda ax: self._blit_cache.pop(ax, None))
self._resize_id = self._fig.canvas.mpl_connect('resize_event',
self._handle_resize)
This was my first contribution to matplotlib. Shall I file another pull request for this modification?
There was a problem hiding this comment.
@onatt, no just modify this PR, add a new commit on your machine, and then push... https://matplotlib.org/devel/index.html
|
As this is a bugfix, should it go in 3.1? |
|
I think that would be appropriate. I think 3.1 branched after it was submitted. |
…itting does not work
|
Something went wrong ... Please have a look at my logs. |
…488-on-v3.1.x Backport PR #13488 on branch v3.1.x (Animation: interactive zoom/pan with blitting does not work)
PR Summary
In an animation using blitting that contains some static graphics elements, the static parts of the figure are not updated after an interactive zoom/pan event. However, they are correctly updated after an resize event (see issue #13478).
PR Checklist