Skip to content

Simplify some annotation() calls in examples. #13549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2019
Merged

Simplify some annotation() calls in examples. #13549

merged 1 commit into from
Mar 1, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 28, 2019

PR Summary

The hopefully noncontroversial parts of #13515.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer mentioned this pull request Feb 28, 2019
Closed
6 tasks
ImportanceOfBeingErnest
ImportanceOfBeingErnest approved these changes Mar 1, 2019
View reviewed changes
Copy link
Member

@ImportanceOfBeingErnest ImportanceOfBeingErnest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are indeed useful simplifications for the examples. I will not directly merge to give someone else the chance to at least look at it.

@ImportanceOfBeingErnest ImportanceOfBeingErnest added this to the v3.1-doc milestone Mar 1, 2019
@timhoffm timhoffm merged commit a45712e into matplotlib:master Mar 1, 2019
@anntzer anntzer deleted the annotation-some-examples branch March 1, 2019 09:42
@QuLogic
Copy link
Member

QuLogic commented Mar 2, 2019

ImportanceOfBeingErnest added this to the v3.1-doc milestone a day ago

@tacaswell This should backport somewhere?

@QuLogic QuLogic modified the milestones: v3.1-doc, v3.1.0 Mar 8, 2019
@QuLogic
Copy link
Member

QuLogic commented Mar 8, 2019

@meeseeksdev backport to v3.1.x

Guess there's no doc branch to backport to yet...

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 8, 2019
@timhoffm
Backport PR matplotlib#13549: Simplify some annotation() calls in exa…
8372879 
…mples.
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 8, 2019
Merged
QuLogic added a commit that referenced this pull request Mar 8, 2019
@QuLogic
Merge pull request #13626 from meeseeksmachine/auto-backport-of-pr-13…
36faab9 
…549-on-v3.1.x

Backport PR #13549 on branch v3.1.x (Simplify some annotation() calls in examples.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@ImportanceOfBeingErnest ImportanceOfBeingErnest ImportanceOfBeingErnest approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @QuLogic @timhoffm @ImportanceOfBeingErnest