Skip to content

Style cleanup to pyplot. #13569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2020
Merged

Style cleanup to pyplot. #13569

merged 1 commit into from
Jul 15, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 2, 2019

... preliminary to more refactoring.

Nearly everything is mechanical; the only subtle point is that figure()
does not need to handle the figure.foo rcParams as the Figure
constructor takes care of that.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer mentioned this pull request Apr 24, 2019
Closed
6 tasks
@anntzer @timhoffm
Style cleanup to pyplot.
70e086e 
... preliminary to more refactoring.

Nearly everything is mechanical; the only subtle point is that figure()
does not need to handle the figure.foo rcParams as the Figure
constructor takes care of that.
@timhoffm timhoffm added this to the v3.4.0 milestone Jul 14, 2020
@timhoffm
Copy link
Member

I've rebased on master.

Even though technically I'm author then, I didn't change any content. So I think it's ok if this is merged with just one more positive review.

@QuLogic QuLogic merged commit deb788d into matplotlib:master Jul 15, 2020
@anntzer anntzer deleted the pyplot-pep8 branch July 15, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @QuLogic