Revert invalid change in Centered Ticklabels example #13578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
approved these changes
Mar 4, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 4, 2019
dstansby
added a commit
that referenced
this pull request
Mar 4, 2019
…578-on-v3.1.x Backport PR #13578 on branch v3.1.x (Revert invalid change in Centered Ticklabels example)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This reverts a change in the example introduced by #8678. As #13400 states
ax.xaxis.set_tick_params(horizontalalignment='right')does not work - it's not implemented.This is a quick-fix to get the documentation correct for 3.1 again.
It's debatable if implementing
vertical/horizontalalignmentforset_tick_params()is reasonable. Essentally, verticalalignment will not give reasonable results for xticks and horizontalalignment will not give reasonable results for yticks. But that's for another PR.