-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Doc event loop requirements for Figure.show #13590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Milestoning 3.1 because it would be nice if this would make it into the docs soon. But feel free to re-milestone. |
I actually think we should just deprecate Figure.show() in favor of e.g. plt.show(figures=[fig1, fig2]) (if you really want to raise just a subset of figures). Figure.show only works for pyplot-managed figures, so it makes sense to have that functionality in pyplot, plus having it it plt.show() will properly spin up the event loop if needed. If you are managing your own GUI then hopefully you are not using pyplot (...), in which case fig.show() is not useful. |
Given #13101 (comment), can we really deprecate Not an expert on this, but there seem to be two differences betweeen the two
|
But |
I think the improvements to Currently |
I'm not talking about deprecating manager.show() (which is indeed needed as a backend customization point), just figure.show(). |
Thanks, I think this will be helpful 👍 |
…590-on-v3.1.x Backport PR #13590 on branch v3.1.x (Doc event loop requirements for Figure.show)
PR Summary
Trying to better document
Figure.show()
and how it's different fromplt.show()
.Hopefully this is reasonably correct and understandable so that #13586 or #13101 do not happen anymore. Improvements welcome as this is hard to describe (see discussion in #13101).