Skip to content

DOC: Make canonical URLs point to versioned path. #13592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Mar 5, 2019

PR Summary

Maybe this will help with #12374. We currently set the canonical URL to the unversioned path (matplotlib.org/page.html); this swaps it to the versioned one (matplotlib.org/3.1.0/page.html).

If this is a development version, it points to /devdocs/ (not sure about this change; maybe it should point to stable?)

PR Checklist

  • [N/A] Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic QuLogic added this to the v3.1.0 milestone Mar 5, 2019
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea

@tacaswell tacaswell merged commit e809b50 into matplotlib:master Mar 5, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 5, 2019
timhoffm added a commit that referenced this pull request Mar 5, 2019
…592-on-v3.1.x

Backport PR #13592 on branch v3.1.x (DOC: Make canonical URLs point to versioned path.)
@QuLogic QuLogic deleted the canonical-docs branch March 5, 2019 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants