-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Improve Demo Text Rotation Mode #13612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5a583a4
to
5d7a515
Compare
I think I liked the old design better, mainly because each case got its own carré, so the alignment is easier to grasp. Also I think showing the bounding box in case of the Code to produce the above (quickly tinkered from the original example - not meant to be taken over literally):
...this is hidden, collapsable content... |
Thanks, showing the bbox is a good idea I've taken over that approach. |
5d7a515
to
d7aaab0
Compare
Drawing the figure multiple times is probably inefficient. Below the example it says 2 seconds, which seems a lot. Maybe one can externalize the part where the rectangles are drawn, such that figure only needs to be drawn once, like
|
d7aaab0
to
e1c3c5d
Compare
Only drawing once saves about 25% of the time. I guess a significant part of the time goes into creating the axes. Anyway, the code is better, so I've applied it. Thanks. |
Looking at the gallery for this, I also found this example; should we merge them together? I like the new look here, but the other one has some different textual explanation as well. |
I’ve seen the other rotation example as well. In principle it would make sense to merge them. However`, I‘ve decided not do it as part of this PR to keep the the changes more managable. Sorting out styling was the main focus of this PR. I‘m happy to do a follow-up. |
Thanks @timhoffm ! |
…612-on-v3.1.x Backport PR #13612 on branch v3.1.x (Improve Demo Text Rotation Mode)
PR Summary
Old example
New example