Simplify PolarAxes.can_pan. #13630
Merged
Simplify PolarAxes.can_pan. #13630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the modified code, dt0 is always == -dt1 so they have the same absolute value and the else clause is always triggered. This is used in polar pan mode, which, when using the left mouse button, allows one to move the radial tick labels around... (the right mouse button allows zooming in and out (changing rmax, which seems less obscure.)
timhoffm
approved these changes
Mar 16, 2019
QuLogic
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the modified code, dt0 is always == -dt1 so they have the same
absolute value and the else clause is always triggered.
This is used in polar pan mode, which, when using the left mouse button,
allows one to move the radial tick labels around... (the right mouse
button allows zooming in and out (changing rmax, which seems less
obscure.)
PR Summary
PR Checklist