Skip to content

Fix FancyArrowPatch joinstyle #13647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2019
Merged

Fix FancyArrowPatch joinstyle #13647

merged 1 commit into from
Mar 11, 2019

Conversation

ImportanceOfBeingErnest
Copy link
Member

PR Summary

Quick attempt to fix #13641

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@ImportanceOfBeingErnest ImportanceOfBeingErnest mentioned this pull request Mar 10, 2019
Closed
@dstansby
Copy link
Member

Would be nice to add a test; if you're happy @ImportanceOfBeingErnest I can try and push one to your branch.

@ImportanceOfBeingErnest
Copy link
Member Author

I wasn't sure what exactly to test here, because present tests do already implicitely check that "round" is the default. But of course you are welcome to suggest a test or directly push one to this branch @dstansby

@dstansby
Copy link
Member

Hmm, this is more complicated than I thought! The change seems reasonable though, so I'll merge.

@dstansby dstansby added this to the v3.2.0 milestone Mar 11, 2019
@dstansby dstansby merged commit eb6eac1 into matplotlib:master Mar 11, 2019
@ImportanceOfBeingErnest ImportanceOfBeingErnest deleted the fancyarrowpatch-joinstyle branch August 2, 2019 21:50
@mpetroff mpetroff mentioned this pull request Oct 17, 2019
Closed
@anntzer anntzer mentioned this pull request Sep 28, 2020
Open
@meakbiyik meakbiyik mentioned this pull request Jan 11, 2021
Closed
@StefRe StefRe mentioned this pull request Dec 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

joinstyle is not respected for FancyArrowPatch (either the path or the arrow heads)
3 participants
@ImportanceOfBeingErnest @dstansby @anntzer