Kill the PkgConfig singleton in setupext. #13663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
commented
Mar 13, 2019
| class PkgConfig(object): | ||
| """This is a class for communicating with pkg-config.""" | ||
|
|
||
| def __init__(self): |
There was a problem hiding this comment.
despite the large diff, most of the PR is just lifting all these implementations up by one indent level.
timhoffm
approved these changes
Mar 16, 2019
PkgConfig.setup_extension works just fine as a free-standing function.
ef5d9ef to
9869c20
Compare
QuLogic
approved these changes
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PkgConfig.setup_extension works just fine as a free-standing function.
PR Summary
PR Checklist