Deduplicate methods shared between Container and Artist. #13702
Conversation
|
w/o checking, does this have any effect on the docs? |
Container does not inherit from Artist, but still shares some of its methods. Instead of duplicating the implementation, just directly use the Artist methods. We could also move these shared methods to a mixin that both Artist and Container inherit, but that would just confuse the matters IMO.
|
Maybe it‘s my strongly typed OOP heritage, but shouldn‘t these methods go into a common base class, maybe a mixin? This feels a bit hacky: Container has now a non-obvious dependency on Artist. |
|
I decided against this making a common base class because it makes things more confusing, not less, IMO (if the base class is private, we have the same problem as with _AxesBase which is that some public methods are defined in a private class; if the base class is public it's kind of an ad-hoc beast (the methods provided don't have much in common except, well, being shared by Artist and Container). |
|
I don't disagree with @timhoffm , but container is already a bit of an oddity in terms of what it is and how it behaves so I think this is better than having duplicated code. |
Container does not inherit from Artist, but still shares some of its
methods. Instead of duplicating the implementation, just directly use
the Artist methods.
We could also move these shared methods to a mixin that both Artist and
Container inherit, but that would just confuse the matters IMO.
PR Summary
PR Checklist