Annotation.contains shouldn't consider the text+arrow's joint bbox. #13708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ff5afbd to
73f410b
Compare
timhoffm
reviewed
May 4, 2019
lib/matplotlib/text.py
Outdated
| @@ -2181,12 +2184,13 @@ def transform(renderer) -> Transform | |||
| else: | |||
| self.arrow_patch = None | |||
|
|
|||
| def contains(self, event): | |||
| contains, tinfo = Text.contains(self, event) | |||
| def contains(self, mouseevent): | |||
There was a problem hiding this comment.
The change of the parameter name is an API change. While, naming of this parameter is not consistent throughout the library, I prefer not to sneek this in with the PR.
That should be handled in a separate PR and unify all contains signatures. It needs at least an API-change note (if not a @cbook._rename_parameter deprecation).
There was a problem hiding this comment.
reverted that change
Previously, when deferring to Text.contains, self.get_window_extent would incorrectly use Annotation.get_window_extent. Just force it to use Text.get_window_extent instead. Also make Annotation obey the optional `._contains` attribute.
73f410b to
c372df2
Compare
timhoffm
approved these changes
May 4, 2019
jklymak
approved these changes
May 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when deferring to Text.contains, self.get_window_extent
would incorrectly use Annotation.get_window_extent. Just force it to
use Text.get_window_extent instead.
Also make Annotation obey the optional
._containsattribute.Also renamed the parameter to Annotation.contains to mouseevent, which is consistent with Text.contains and most other contains() methods. I decided to skip the deprecation on that...
Closes #10875.
PR Summary
PR Checklist