Skip to content

TST: only test agg_filter extensions with baseline images #13710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2019
Merged

TST: only test agg_filter extensions with baseline images #13710

merged 1 commit into from
Mar 19, 2019

Conversation

tacaswell
Copy link
Member

Follow up to #13021

This will not backport and should be manually added to #13704

@tacaswell tacaswell added this to the v3.1.0 milestone Mar 19, 2019
@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Mar 19, 2019
@anntzer anntzer merged commit 9faf231 into matplotlib:master Mar 19, 2019
@lumberbot-app
Copy link

lumberbot-app bot commented Mar 19, 2019

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.1.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 9faf2313cf0e37a6b01ad691b8a430eb2b4ebe3f
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #13710: TST: only test agg_filter extensions with baseline images'
  1. Push to a named branch :
git push YOURFORK v3.1.x:auto-backport-of-pr-13710-on-v3.1.x
  1. Create a PR against branch v3.1.x, I would have named this PR:

"Backport PR #13710 on branch v3.1.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@tacaswell tacaswell mentioned this pull request Mar 19, 2019
Merged
2 tasks
@tacaswell tacaswell deleted the tst_fix_aggfilter_test branch March 24, 2019 23:30
tacaswell pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 25, 2019
@anntzer @tacaswell
Merge pull request matplotlib#13710 from tacaswell/tst_fix_aggfilter_…
9e0e738 
…test

TST: only test agg_filter extensions with baseline images
@tacaswell
Copy link
Member Author

backport merged as part of #13704

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tacaswell @jklymak @QuLogic @anntzer