Check for already running QApplication in Qt embedding example. #13731
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes (part of) #13400.
I decided against calling
QtWidgets.QApplication.setQuitOnLastWindowClosed(True)
because this was explicitly set from IPython (https://github.com/ipython/ipykernel/blob/master/ipykernel/eventloops.py#L117) so it seems counterproductive to undo their choice here. The default is already true (https://doc.qt.io/qt-5/qguiapplication.html#quitOnLastWindowClosed-prop) so we should generally assume that if someone set it to false, they know what they're doing.PR Checklist