Skip to content

GUI: add font widget for title with Qt #13772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

weber-s
Copy link

@weber-s weber-s commented Mar 27, 2019

PR Summary

This is just a simple PR playing with Qt backend because I wanted to change the font size of an ax title without going through the interpreter.

I did not find anything related to guideline concerning the GUI, so I started this PR.

Please let me know if some GUI development are welcome, if so, I may continue.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@weber-s weber-s changed the title GUI: allow fontsize change for title with Qt GUI: add font widget for title with Qt Mar 28, 2019
@timhoffm
Copy link
Member

Thanks for the PR!

I'm a bit undecided on this. I don't think we have an official policy concerning the GUIs. Neither how far we want to go, nor if we aim at feature parity throughout the GUI frameworks (#13195).

I'm wondering where we want to draw the line. One the one hand, adding this bit of code is not too difficult. On the other hand, next would immediately be font settings for axes labels. This is cluttering up the dialog. Also, we certainly cannot add GUI elements for every parameter. That would be too much of an effort and maintenance burden.

A solution to part of the issues could be to define a StyledTextWidget and use that instead of the simple QLineEdit for texts. This widget would contain the QLineEdit for the text and a font-settings button to the right that would either open a separate font settings dialog or fold/unfold a font settings panel below the QLineEdit.

But before going down this road, I think the dev team should make some fundamental decisions on the scope of the GUI. - In the end we have to maintain it all.

@tacaswell tacaswell added this to the v3.2.0 milestone Mar 31, 2019
@dstansby dstansby added the status: needs comment/discussion needs consensus on next step label Aug 14, 2019
@tacaswell tacaswell modified the milestones: v3.2.0, v3.3.0 Aug 26, 2019
@tacaswell
Copy link
Member

Pushing to 3.3.

@efiring
Copy link
Member

efiring commented Apr 7, 2020

My old-school view is that the GUIs should be kept pretty simple. If there is demand for a high degree of configurability via a GUI, perhaps that should be a separate project.

@tacaswell tacaswell modified the milestones: v3.3.0, unassigned Apr 13, 2020
@tacaswell
Copy link
Member

tacaswell commented Apr 13, 2020

Thank you for your work on this (and the extreme delay on getting this reviewed!), however I don't think we are going to take this. In addition to the concerns about this being something we want to support as a library, this is implemented as text box that does not do any validation on the font names.

I hope we hear from you again.

@tacaswell tacaswell closed this Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants