Skip to content

Fixes incorrect error bar colors when NaN values are present #13825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fixes incorrect error bar colors when NaN values are present #13825

wants to merge 3 commits into from

Conversation

kasanitej
Copy link

PR Summary

incorrect error bar colors when NaN values are present
#13799

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic
Copy link
Member

QuLogic commented Apr 1, 2019

Please give your PRs descriptive titles; what does this change do?

@kasanitej
Copy link
Author

Hi,

This PR pertains to issue reported in #13799.

My change will look into the corresponding index of the color of X & Y where there are np.nan, and remove them.

Regards,
Bhanu.

@anntzer
Copy link
Contributor

anntzer commented Apr 10, 2019

I think(??) the correct fix is to keep the invalid values in everywhere but not plot them, similarly to #12422.

@kasanitej
Copy link
Author

kasanitej commented Apr 10, 2019 •
edited
Loading

yeah.. that's sound better than removing them. I will check it. Thanks for suggestion.

@NelleV NelleV changed the title Pull/13799 Fixes incorrect error bar colors when NaN values are present Apr 10, 2019
@NelleV
Copy link
Member

NelleV commented Apr 10, 2019

I would also raise a warning.

@jklymak
Copy link
Member

jklymak commented Jul 23, 2020

Superseded by #16724

@jklymak jklymak closed this Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kasanitej @QuLogic @anntzer @NelleV @jklymak @dstansby