MNT: account for cpython deprecations #13836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The # variants the PyArg formats will raise deprecation warnings in py38. https://bugs.python.org/issue8677 https://bugs.python.org/issue36381 python/cpython#12473 python/cpython@d3c72a2
timhoffm
approved these changes
Apr 2, 2019
jklymak
approved these changes
Apr 2, 2019
|
Should this at least go in for 3.1.1? |
|
I'm convinced on backporting to 3.1. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Apr 2, 2019
|
Should this get backported to the LTS?
…On Tue, Apr 2, 2019 at 12:57 PM Jody Klymak ***@***.***> wrote:
Merged #13836 <#13836> into
master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#13836 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARy-NLMZGavG4QixvdLZVC_X0m3J1_qks5vc4vmgaJpZM4cWzUY>
.
|
|
Will people using py 3.8 really be using MPL 2.2.4? |
|
I doubt that someone will be using py3.8 and mpl2.2.4 |
|
One can speculate all they want about whether that combination would occur.
The important question is what did we promise for the v2.2 LTS policy?
…On Tue, Apr 2, 2019 at 3:48 PM Tim Hoffmann ***@***.***> wrote:
I doubt that someone will be using py3.8 and mpl2.2.4
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#13836 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARy-FW3BzPb-IQAhsaAu-L09Okmw4k3ks5vc7PxgaJpZM4cWzUY>
.
|
|
We said critical bug fixes to 2020. You see these warnings in the test logs, not sure if you see them under normal operation. Lets see if these go cleanly... @meeseeksdev backport to v2.2.x |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
Closed
dstansby
added a commit
that referenced
this pull request
Apr 8, 2019
…836-on-v3.1.x Backport PR #13836 on branch v3.1.x (MNT: account for cpython deprecations)
|
backported in #13846 |
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Oct 19, 2019
MNT: account for cpython deprecations The conflicts were due to other changes in the #includes in the affected files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The # variants the PyArg formats will raise deprecation warnings in
py38.
https://bugs.python.org/issue8677
https://bugs.python.org/issue36381
python/cpython#12473
python/cpython@d3c72a2
We should have done this a while ago 🤷♂️ .