Skip to content

Ensure figsize is positive finite #13859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2019
Merged

Ensure figsize is positive finite #13859

merged 1 commit into from
Apr 4, 2019

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Apr 3, 2019

PR Summary

Fixes #13857. We were only checking for finite figsize. Changed that to positive finite.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant

WeatherGod
WeatherGod previously requested changes Apr 3, 2019
View reviewed changes
Copy link
Member

@WeatherGod WeatherGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a style fix. Otherwise, looks good.

lib/matplotlib/tests/test_figure.py

def test_invalid_figure_add_axes():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need two blank lines here, which is what travis is failing on.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style fixed.

@timhoffm timhoffm requested a review from WeatherGod April 4, 2019 00:20
@tacaswell tacaswell added this to the v3.2.0 milestone Apr 4, 2019
@timhoffm
Copy link
Member Author

timhoffm commented Apr 4, 2019

This is ready to merge.

@anntzer anntzer merged commit 0f0ef9c into matplotlib:master Apr 4, 2019
@anntzer anntzer mentioned this pull request Apr 4, 2019
Merged
6 tasks
@timhoffm timhoffm deleted the positive-figsize branch April 5, 2019 00:43
@amueller
Copy link
Contributor

amueller commented Apr 5, 2019

Thanks!

@tacaswell tacaswell mentioned this pull request Mar 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@dstansby dstansby dstansby approved these changes

@WeatherGod WeatherGod Awaiting requested review from WeatherGod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@timhoffm @amueller @WeatherGod @anntzer @dstansby @tacaswell